Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

agent: fix panic when logging about protocol version config use. #12962

Merged
merged 2 commits into from
May 13, 2022
Merged

agent: fix panic when logging about protocol version config use. #12962

merged 2 commits into from
May 13, 2022

Conversation

jrasell
Copy link
Member

@jrasell jrasell commented May 12, 2022 •
edited
Loading

The log line comes before the agent logger has been setup,
therefore we need to use the UI logging to avoid panic.

@jrasell
agent: fix panic when logging about protocol version config use.
b54ae21 
The log line comes before the agent logger has been setup,
therefore we need to use the UI logging to avoid panic.
@jrasell jrasell requested review from schmichael and tgross May 12, 2022 08:19
@jrasell jrasell self-assigned this May 12, 2022
tgross
tgross approved these changes May 12, 2022
View reviewed changes
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

schmichael
schmichael approved these changes May 12, 2022
View reviewed changes
Copy link
Member

@schmichael schmichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, not sure how I missed this in #11600. I suppose the other references to c.Ui throughout this method really should be a strong enough hint to folks about how to log.

Thanks for fixing this up so quickly.

@jrasell jrasell added the backport/1.3.x backport to 1.3.x release line label May 13, 2022
@jrasell jrasell merged commit bab219a into main May 13, 2022
@jrasell jrasell deleted the b-gh-12960 branch May 13, 2022 07:28
@hc-github-team-nomad-core hc-github-team-nomad-core mentioned this pull request May 13, 2022
Merged
lgfa29 pushed a commit that referenced this pull request May 19, 2022
@jrasell @lgfa29
agent: fix panic when logging about protocol version config use. (#12962
e79bc2e 
)

The log line comes before the agent logger has been setup,
therefore we need to use the UI logging to avoid panic.
lgfa29 pushed a commit that referenced this pull request May 19, 2022
@jrasell @lgfa29
agent: fix panic when logging about protocol version config use. (#12962
fd9fe46 
)

The log line comes before the agent logger has been setup,
therefore we need to use the UI logging to avoid panic.
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmichael schmichael schmichael approved these changes

@tgross tgross tgross approved these changes

Assignees

@jrasell jrasell

Labels
backport/1.3.x backport to 1.3.x release line
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrasell @schmichael @tgross